Последнии сообщения форума
Replace all remaining inline HTML across blocks, core modules, admin panel, and frontend modules with template fragments, completing the full separation of PHP logic from HTML output across the entire codebase.
Core changes:
- Blocks (18 files — blocks/block-*.php):
- All inline HTML replaced with getHtmlFrag() fragment calls
New fragments added: block-banner-random, block-center-, block-forum-, block-img-, block-languages-, block-login-form, block-menu, block-module-*, block-network-row, block-search-form, block-stat-banners, block-user-*
- Core (core/access.php, admin.php, classes/pdo.php, security.php, user.php):
- access.php / security.php: error/report output migrated to fragments
- pdo.php: query debug output uses pdo-error-badge / pdo-query-time fragments
- user.php: RSS feed builder uses user.php-specific fragments
- admin.php: remaining inline HTML moved to fragments
- Frontend modules (modules/):
account, changelog, clients, contact, content, faq, files, forum, help, jokes, links, main, media, news, order, pages, search — all cleaned
- forum/index.php: full rewrite using link-btn, span-btn, forum-* fragments
- main/index.php: carousel, grid and section output via main-* fragments
- search/index.php: result rendering via search-result-title fragment
- Templates (templates/):
- admin/index.php, lite/index.php: asset and layout output via fragments
- media-post-badge.html synced across default/lite/simple themes
- ~350 new .html fragment files added across all 4 theme directories
Benefits: - PHP files contain zero HTML tags (except filterMarkdown engine and RSS/XML) - All HTML exclusively in .html fragment files under templates/ - Themes can now be fully swapped without touching any PHP logic - Fragment sync enforced by phpunit testSharedFrontendFragmentsStayInSyncAcrossThemes
Technical notes: - 125/125 phpunit tests pass (1 pre-existing CRLF failure unchanged) - All shared frontend fragments are hash-identical across default/lite/simple/admin - Admin-only fragments remain in templates/admin/fragments/ only
Replace every inline HTML tag in admin modules, frontend modules, and core helper functions with template fragments or existing helper calls, completing the full PHP-without-HTML migration across the entire codebase.
Core changes:
- Core functions (core/system.php):
- categorySelectOption(): delegate to getTplOption() — removes <option> inline HTML
- title_tip(): use title-tip.html fragment — removes <nav><div> inline HTML
- ad_status(): use span-btn.html / link-btn.html — removes all <span>/<a> inline HTML
- New shared fragments (all 4 themes: default/lite/simple/admin):
- title-tip.html: <nav class="sl_tip"><div>{{{ content }}}</div></nav>
- rating-box.html: <div class="min-rate"><div class="rate-like-box">{{{ content }}}</div></div>
- form-checkall.html: checkall <input> for list headers
- td-check.html: <td><input type="checkbox"> for list rows
- tr-open.html / tr-close.html: structural table row wrappers
- img-preview.html: <img id="picture"> for config image preview
- Admin modules (19 files):
- adminTitleTipLabel/adminTitleTip with <br> separators → getTplAdminTipLine()
- getcat(..., '<option>') → getcat(..., getTplOption())
- <a href target="_blank"> links → getTplAdminTextLink()
- <br><br> before fields → $tpl->getHtmlFrag('br-br', [])
- <div>...<hr> voting preview → div-hr.html fragment
- <tr>/<\/tr> in news asso table → tr-open.html / tr-close.html
- <th> checkall → th-nosort.html + form-checkall.html
- <td> checkbox → td-check.html
- <img> preview → img-preview.html
- activate() in money/order: add global $tpl, use br-br fragment for email
- Frontend modules (5 files):
- rss/index.php: <option selected> → getTplOption(..., true)
- users/index.php: <br> tip lines → getTplAdminTipLine(); <div rating> → rating-box.html
- shop/index.php: <br> tip lines → getTplAdminTipLine() in $website/$note
- money/index.php: $sinfo .= val.<br> → getTplAdminInfoLine()
- voting/index.php: <div id="rep..."> → post-div.html fragment
Benefits: - Zero raw HTML tags remain in any module or core helper PHP file - All HTML exclusively lives in .html fragment files under templates/ - categorySelectOption, title_tip, ad_status now fully template-driven - 125/125 phpunit tests pass (1 pre-existing CRLF failure unchanged)
Technical notes: - Justified exceptions: filterMarkdown class (IS the HTML generator), PDO constructor error path ($tpl unavailable), template engine asset management (circular dependency), RSS/XML generation, commented-out code - New fragments synced across all 4 theme dirs (hash-identical per phpunit) - getTplAdminTipLine trailing-<br> differs slightly from original leading-<br> pattern in tooltips — visually equivalent, no behavioral change
Externalize the editor page's structural HTML and interactive components, such as the Robots.txt button and notification panels, into dedicated Mustache-style fragments to improve controller clarity and UI reuse.
Core changes:
- Editor management (admin/modules/editor.php):
- Use getHtmlFrag to load the new editor structural components
- Replace inline Robots.txt button generation with the admin-editor-robots-button fragment
- Move the note panel and root container structural logic to dedicated fragments
- New Fragments (templates/admin/fragments/admin-editor-*):
- admin-editor-robots-button: Standardized green button for Robots.txt templates
- admin-editor-note-panel: Flexible container for notifications and warnings
- admin-editor-root-panel: Main container for the editor interface
Benefits: - Decouples structural HTML from the editor's PHP controller logic - Consistent button styling for all editor templates - Cleaner DOM structure with standardized panel containers
Technical notes: - Uses the core getHtmlFrag() method for fragment retrieval - The Robots.txt button logic is encapsulated in the fragment but relies on existing external JS handling - All structural changes are backward compatible with the current admin layout
Standardize the rendering of admin tables, status badges, and anchor links across various core and module management panels. Replaces repetitive HTML string concatenation with the new helper suite.
Core changes:
- Language and Module Management (admin/modules/lang.php, modules.php):
- Use getTplAdminTableHead for sorting-aware header generation
- Use getTplAdminStatusBadge for standardized status indicators
- Scheduler and Sitemap (admin/modules/scheduler.php, modules/sitemap/admin/index.php):
- Replace inline links with getTplAdminTextLink
- Use getTplAdminTipLine/InfoLine for descriptive list items
- Forum and Monitor (modules/forum/admin/index.php, admin/modules/monitor.php):
- Use getTplAdminTableCells for clean row generation
- Replace ad-hoc span tags with getTplSpan
Benefits: - Consistent look and feel for all admin data tables - Unified attribute escaping for all generated anchor tags - Simplified module controllers by moving HTML logic to core helpers
Technical notes: - Supports both sortable and non-sortable columns via getTplAdminTableHead - All textual labels are properly escaped by the underlying helpers - Backward compatible: resulting HTML matches the existing admin styles
Replace inline HTML <div> strings with standardized UI helper functions (getTplAdminHintLabel, getTplAdminSmallNote) in the blocks, configuration, and account modules to ensure consistent styling and encapsulation.
Core changes:
- Blocks management (admin/modules/blocks.php):
- Use getTplAdminSmallNote for RSS lines information row
- Configuration (admin/modules/config.php):
Replace inline <div> hints with getTplAdminHintLabel for captcha, SEO, and graph settings to maintain visual consistency
- User accounts (modules/account/admin/index.php):
- Update the mail password text panel to use the admin-admins-mail-panel fragment
Benefits: - Consistent presentation of hints and small notes across admin forms - Cleaner module templates that focus on structure rather than inline HTML - Improved maintainability through encapsulated presentation logic
Technical notes: - Uses helpers defined in core/helpers.php - Fragments are loaded via the standard getHtmlFrag() method - Backward compatible: visual output remains consistent with the previous implementation
Unify error message rendering across various admin modules by replacing inline implode('<br>', ...) with the shared getStopText() helper. Ensures consistent handling of empty error array entries and line breaks.
Core changes:
- Admin modules (modules/*/admin/index.php):
- Replace inline implode('<br>', \) with getStopText((array)\)
- Affected modules: auto_links, clients, files, help, jokes, links, media, money, news, order, pages, shop
Benefits: - Centralized logic for formatting error messages - Improved code readability across multiple modules - Consistent UI presentation for warnings and error alerts
Technical notes: - getStopText is a core helper from core/helpers.php - (array) cast added for safety where \ variable might be null or scalar - No functional change to the rendered HTML output
Introduce two new Mustache-style HTML fragment files that render a checkbox table for selecting news items associated with a record, keeping the markup out of PHP and in the template layer.
Core changes:
- Associated news table wrapper (admin-news-asso-table.html):
Renders an sl_form table element with {{{ rows_html }}} slot * rows_html is populated by iterating admin-news-asso-cell fragments
- Associated news cell (admin-news-asso-cell.html):
Renders a single <td> with a named checkbox input * name: associated[], value: {{ cid }}, checked state: {{{ checked }}} * Displays article title {{ ctitle }} as inline label text
Benefits: - Separates HTML structure from PHP controller logic - Reusable fragments composable via getHtmlFrag() calls - Consistent with existing admin fragment template conventions
Technical notes: - Triple-brace {{{ }}} used for pre-rendered HTML slots (rows_html, checked) - Double-brace {{ }} used for plain-text values (cid, ctitle) requiring escaping - Backward compatible: fragments are new additions, no existing files changed
--------------------------------------------------------------------
Types: Refactor | Feature | Fix | Docs | Style | Test | Chore | Perf
Bullets: - main point, * sub-detail
--------------------------------------------------------------------
Unify stop/error message rendering across modules by replacing ad-hoc inline implode('<br>', ...) calls with the new shared getStopText() helper introduced in core/helpers.php, removing the now-redundant local getAdmintext() wrapper from admins.php.
Core changes:
- Admin admins module (admin/modules/admins.php):
- Remove local getAdmintext(array \) function (replaced by getStopText)
- Replace getAdmintext(\) call with getStopText(\) in add()
- Whois admin module (modules/whois/admin/index.php):
- Replace inline implode('<br>', \) with getStopText((array)\)
- Private messages (core/user.php):
- Replace inline implode('<br>', (array)\) with getStopText((array)\)
Benefits: - Single source of truth for error message formatting - Eliminates duplicate logic across three independent modules - Consistent handling of empty/null stop entries via array_filter
Technical notes: - getStopText filters empty strings via array_filter before joining - Cast to (array) preserved where \ may be a scalar at call site - Backward compatible: output is identical to previous inline logic
--------------------------------------------------------------------
Types: Refactor | Feature | Fix | Docs | Style | Test | Chore | Perf
Bullets: - main point, * sub-detail
--------------------------------------------------------------------
Add a set of small, focused helper functions that generate reusable HTML fragments for admin panels, keeping presentation logic in helpers and out of individual module files.
Core changes:
- New UI helper functions (core/helpers.php):
- getTplAdminSmallNote(text): standalone sl_small note div for label-less form rows
- getStopText(stop): joins non-empty error/stop messages with <br> separators
- getTplAdminTextLink(href, label, ...): safe anchor tag for use inside raw HTML slots
- getTplAdminTipLine(key, val): one key-value line for tooltip content_html strings
- getTplAdminInfoLine(label, value): one label-value line for info block content
- getTplAdminTableHead(cols): builds <th> head_html from column label arrays
- getTplAdminTableCells(cells): builds <td> cells_html from pre-rendered cell content array
- getTplSpan(class, raw_content, title): inline span with CSS class and optional title
- getTplAdminStatusBadge(state, yes, no): sl_green/sl_red badge span for status display
Benefits: - Eliminates repetitive inline HTML string construction across modules - Centralises HTML-escaping rules in one place, reducing XSS risk - Provides a consistent API for all admin panel fragment generation
Technical notes: - All attribute values are escaped via htmlspecialchars with ENT_QUOTES/UTF-8 - raw_content in getTplSpan is intentionally not escaped (caller responsibility) - Backward compatible: no existing signatures changed
--------------------------------------------------------------------
Types: Refactor | Feature | Fix | Docs | Style | Test | Chore | Perf
Bullets: - main point, * sub-detail
--------------------------------------------------------------------
Same %20 space-encoding issue as the Migration badge. Replaced %20 with _ for consistency and reliable rendering on GitHub.
Core changes:
- Badge URL (README.md):
- Replace %20 with _ in Status badge URL
Technical notes: - shields.io treats _ as space in path-based badge URLs





